[ModelicaSystem*] add timeout argument #382
Conversation
syntron
force-pushed
the
ModelicaSystem_timeout
branch
from
ecd996f to
d37ec0b
Compare
adeas31
left a comment
adeas31
left a comment
There was a problem hiding this comment.
ModelicaSystemDoE and ModelicaSystem doesn't really need timeout. The timeout is used by OMCSessionZMQ so it is better to expose timeout with API so it can be set to something else other than default 10s.
I also saw that timeout is used very randomly in the code. For starting omc we are using timeout of 2s and then each process class also uses timeout. It is also used for command execution. Perhaps its better to clean up the code and use timeout properly.
|
@adeas31 update the code to: |
syntron
force-pushed
the
ModelicaSystem_timeout
branch
from
181b9a1 to
f9d995c
Compare
|
move point (1) to PR #383; this PR could be applied now the remaining changes should be applied after the modifications of OMCSession as it changes the same code and this means only one (final) rebase |
2 participants
Add / fix argument timeout to / of ModelicaSystem and ModelicaSystemDoE